Bundle libsrt (support SRT protocol) #1619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason on OS X the .dylib is not found at runtime, try to use CMAKE_INSTALL_RPATH_USE_LINK_PATH.
This avoids picking up homebrew's libpng on OS X which may not be built for the target OS X version.
This avoids picking up homebrew's libintl on OS X which may not be built for the target OS X version.
- use Windows builds from gyan.dev - update to FFmpeg 4.3.2 - install ninja using pip - install zlib instead of building it - pin dav1d to version 0.9.2 - explicitly disable libxcb on Linux
cibuildwheel already sets MACOSX_DEPLOYMENT_TARGET
Implements the "mpeg4" codec that ffmpeg can already do.
We want to parse ASS/SSA, but we don't need rendering.
The old Docker environment must have changed. Moving libraries now doesn't work so stage 1 and 2 have been combined. I also cut out unneeded/problematic libraries like freetype. I'll see if libbluray and gnutls can be enabled again. openjpeg only implements jpeg2000, not jpeg or jpegxl, so that's why it's removed.
JoeSchiff
force-pushed
the
srt
branch
4 times, most recently
from
c9a54a3 to
ed063e6
Compare
WyattBlue
changed the title
WyattBlue
changed the title
|
It looks like PyAV already supports SRT (at least for decoding) if the user compiles libSRT in. This code installs libsrt for testing, but you don't need that right unless you have a srt protocol test. Look at https://github.com/PyAV-Org/PyAV-ffmpeg if you want to bundle libSRT in the pypi binary wheels. |
|
Thanks for the feedback. I'll check it out. Do you think an srt protocol test is necessary (or feasible)? |
Feasible? Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will solve: #1503
Notes
SRT requires GnuTLS. Is there a cleaner way to install the package without globbing?
Testing
I would like to set up a test for this, but I don't know how to start streaming a video from within pyav. I was able to create a network live stream with ffmpeg like this:
ffmpeg -i local_file.mp4 -c:v libx264 -f mpegts 'srt://127.0.0.1:40052?mode=listener&latency=2000000'I then opened the network stream in pyav with:
Pyav decoded the network stream and everything seemed to work.
If anyone knows how to create a network stream in pyav, I could write a test for this.