Use pytest instead of setup.py test

.github/workflows/smoke.yml

@@ -24,9 +24,6 @@ jobs:
         with:
           python-version: "3.12"
 
-      - name: Packages
-        run: pip install -r tests/requirements.txt
-
       - name: Linters
         run: make lint
 

Makefile

@@ -2,7 +2,9 @@ LDFLAGS ?= ""
 CFLAGS ?= "-O0"
 
 PYAV_PYTHON ?= python
+PYAV_PIP ?= pip
 PYTHON := $(PYAV_PYTHON)
+PIP := $(PYAV_PIP)
 
 
 .PHONY: default build clean fate-suite lint test
@@ -11,6 +13,8 @@ default: build
 
 
 build:
+	# Always try to install the Python dependencies they are cheap.
+	$(PIP) install --upgrade -r tests/requirements.txt
 	CFLAGS=$(CFLAGS) LDFLAGS=$(LDFLAGS) $(PYTHON) setup.py build_ext --inplace --debug
 
 clean:
@@ -25,10 +29,12 @@ fate-suite:
 	rsync -vrltLW rsync://fate-suite.ffmpeg.org/fate-suite/ tests/assets/fate-suite/
 
 lint:
+	$(PIP) install --upgrade -r tests/requirements.txt
 	black --check av examples tests setup.py
 	flake8 av examples tests
 	isort --check-only --diff av examples tests
 	mypy av tests
 
 test:
-	$(PYTHON) setup.py test
+	$(PIP) install --upgrade -r tests/requirements.txt
+	$(PYTHON) -m pytest

scripts/activate.sh

@@ -9,10 +9,13 @@ fi
 export PYAV_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.."; pwd)"
 
 if [[ ! "$PYAV_LIBRARY" ]]; then
-
-    # Pull from command line argument.
     if [[ "$1" ]]; then
-        PYAV_LIBRARY="$1"
+        if [[ "$1" == ffmpeg-* ]]; then
+            PYAV_LIBRARY="$1"
+        else
+            echo "Error: PYAV_LIBRARY must start with 'ffmpeg-'" >&2
+            return 1
+        fi
     else
         PYAV_LIBRARY=ffmpeg-7.0.1
         echo "No \$PYAV_LIBRARY set; defaulting to $PYAV_LIBRARY"

scripts/build-deps

@@ -8,12 +8,11 @@ fi
 cd "$PYAV_ROOT"
 
 # Always try to install the Python dependencies they are cheap.
-$PYAV_PIP install --upgrade -r tests/requirements.txt
-
+$PYAV_PIP install --upgrade -r tests/requirements.txt 2> /dev/null
 
 # Skip the rest of the build if it already exists.
 if [[ -e "$PYAV_LIBRARY_PREFIX/bin/ffmpeg" ]]; then
-    echo "We have a cached build of $PYAV_LIBRARY; skipping re-build."
+    echo "We have a cached build of ffmpeg-$PYAV_LIBRARY; skipping re-build."
     exit 0
 fi
 

scripts/test

@@ -19,7 +19,7 @@ istest() {
 }
 
 if istest main; then
-    $PYAV_PYTHON setup.py test
+    $PYAV_PYTHON -m pytest
 fi
 
 if istest examples; then

tests/requirements.txt

@@ -5,5 +5,6 @@ black
 isort
 flake8
 flake8-pyproject
+pytest
 sphinx==5.1.0
 mypy==1.10.0