Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of splitting queries #52

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

Conversation

Petterandre
Copy link
Contributor

@Petterandre Petterandre commented Nov 25, 2020

Your checklist for this pull request

  • Make sure you are requesting to pull a feature/bugfix/issue branch (right side).
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off our dev branch.

Description

Splits queries in @common

How to test

Several projects required. Above 40 most likely.
Add all to Program.
Navigate to Program Portfolio
View Network tab if two post queries are made to the REST API.
If successful, all projects should be viewable.

Repeat this for BenefitsOverview, ProgramDeliveries, RiskOverview, ResourceAllocation

Relevant issues (if applicable)

Closes #51

It ain't pretty, I know. Looking for alternative string splitting.
@Petterandre
Copy link
Contributor Author

I require some backup here.

I don't like the way I am currently creating the array of strings, it looks... not good.
This will require changes in PP2 code, but I think this is inevitable.

@olemp olemp changed the title First draft First draft of splitting queries Nov 25, 2020
@olemp
Copy link
Collaborator

olemp commented Nov 25, 2020

I require some backup here.

I don't like the way I am currently creating the array of strings, it looks... not good.
This will require changes in PP2 code, but I think this is inevitable.

Cleaned up the build function a little. There's still quite some changes needed. Also in prosjektportalen.

@olemp olemp added the draft label Dec 18, 2020
@olemp olemp self-requested a review December 18, 2020 15:21
@olemp olemp removed their assignment Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants