Build/support versioned branches #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psibean
commented
Aug 6, 2024
| @@ -176,5 +176,3 @@ export interface DoubleCsrfUtilities { | |||
| */ | |||
| doubleCsrfProtection: doubleCsrfProtection; | |||
| } | |||
|
|
|||
| export {}; | |||
There was a problem hiding this comment.
This isn't actually needed, without it, rollup builds things properly, so this avoids the issue that required the 3.0.5 and 3.0.6 releases
|
I am late but looks good to me👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to keep in mind that the
branchesproperty doesn't use regex values. It usesfnmatchfrom ruby. It's a bit of a pain in the ass, but for now this will do until we hit v10.This change should ensure PR's targeting
v3.x.xand eventuallyv4.x.xget built and tested checks against them.