Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/per token cookie settings #60

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Conversation

psibean
Copy link
Contributor

@psibean psibean commented Apr 5, 2024

Provides the ability to override the cookieOptions on a per token generation basis.

@psibean psibean requested a review from davidgonmar April 5, 2024 16:28
@psibean psibean force-pushed the feat/per-token-cookie-settings branch 2 times, most recently from 27f2833 to ad50ab2 Compare April 5, 2024 16:36
src/index.ts Show resolved Hide resolved
src/types.ts Show resolved Hide resolved
When calling `generateToken` the third options object parameter
can now take a cookieOptions property to override any of the initial
cookieOptions that were provided.

This commit also removes the forced httpOnly true option.

E.g. generateToken(req, res, { cookieOptions })
@psibean psibean force-pushed the feat/per-token-cookie-settings branch from ad50ab2 to e07dcfe Compare April 6, 2024 04:45
@psibean psibean requested a review from davidgonmar April 6, 2024 04:46
@psibean psibean mentioned this pull request Apr 6, 2024
@psibean psibean merged commit 5e5ba9b into main Apr 7, 2024
7 checks passed
psibean added a commit that referenced this pull request Sep 21, 2024
When calling `generateToken` the third options object parameter
can now take a cookieOptions property to override any of the initial
cookieOptions that were provided.

This commit also removes the forced httpOnly true option.

E.g. generateToken(req, res, { cookieOptions })
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants