changing dot size in plot depending if new submission #75 #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enryH
reviewed
Sep 25, 2023
webinterface/_base.py
Outdated
| @@ -36,7 +36,7 @@ def _preface(self): | |||
| unsafe_allow_html=True, | |||
| ) | |||
|
|
|||
| @abstractmethod | |||
| @abstractmethod | |||
There was a problem hiding this comment.
can you install the black formatting plugin in VSCode?
|
So both your changes are due to formatting. We use black for formatting the code and it can be installed as a plugin in VSCode: https://marketplace.visualstudio.com/items?itemName=ms-python.black-formatter |
enryH
reviewed
Sep 25, 2023
| all_datapoints = all_datapoints.T | ||
|
|
||
| current_datapoint["old_new"] = "new" |
There was a problem hiding this comment.
Alternatively you could remember the index and use df.loc[idx_new]
enryH
reviewed
Sep 25, 2023
| @@ -75,12 +75,25 @@ def plot_metric(self, benchmark_metrics_df: pd.DataFrame) -> go.Figure: | |||
|
|
|||
| # Add hover text | |||
| hover_texts = [ | |||
| f"Search Engine: {benchmark_metrics_df.search_engine[idx]} {benchmark_metrics_df.software_version[idx]}<br>FDR psm: {benchmark_metrics_df.fdr_psm[idx]}<br>FDR Peptide: {benchmark_metrics_df.fdr_peptide[idx]}<br>FRD Protein: {benchmark_metrics_df.fdr_protein[idx]}<br>MBR: {benchmark_metrics_df.MBR[idx]}<br>Precursor Tolerance: {benchmark_metrics_df.precursor_tol[idx]} {benchmark_metrics_df.precursor_tol_unit[idx]}<br>Fragment Tolerance: {benchmark_metrics_df.fragment_tol_unit[idx]}<br>Enzyme: {benchmark_metrics_df.enzyme_name[idx]} <br>Missed Cleavages: {benchmark_metrics_df.missed_cleavages[idx]}<br>Min peptide length: {benchmark_metrics_df.min_pep_length[idx]}<br>Max peptide length: {benchmark_metrics_df.max_pep_length[idx]}" | |||
| f"Search Engine: {benchmark_metrics_df.search_engine[idx]} {benchmark_metrics_df.software_version[idx]}<br>" + | |||
enryH
approved these changes
Sep 25, 2023
| f"Search Engine: {benchmark_metrics_df.search_engine[idx]} {benchmark_metrics_df.software_version[idx]}<br>" | ||
| + f"FDR psm: {benchmark_metrics_df.fdr_psm[idx]}<br>" | ||
| + f"FDR Peptide: {benchmark_metrics_df.fdr_peptide[idx]}<br>" | ||
| + f"FRD Protein: {benchmark_metrics_df.fdr_protein[idx]}<br>" |
There was a problem hiding this comment.
Suggested change
| + f"FRD Protein: {benchmark_metrics_df.fdr_protein[idx]}<br>" | |
| + f"FDR Protein: {benchmark_metrics_df.fdr_protein[idx]}<br>" |
scaramonche
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.