Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] 케이크샵 불러오기 버그 수정 #101

Merged
merged 2 commits into from
Aug 25, 2023
Merged

[bug] 케이크샵 불러오기 버그 수정 #101

merged 2 commits into from
Aug 25, 2023

Conversation

lee989898
Copy link
Contributor

Related issue

Work Description

  • 지역 선택하고 디테일 화면 들어갔다 메인 화면 오면 케이크샵 두 배로 늘어나는 버그 수정

Uncompleted Tasks

  • 케이크샵 두 배로 늘어나는 버그 수정

@lee989898 lee989898 self-assigned this Aug 25, 2023
@lee989898
Copy link
Contributor Author

image

sealed class 안에서 object를 data object로 쓰라고 주의뜨더라고
data object 찾아보니까 data class처럼 toString 같은 것들은 편하게 쓸 수 있게 오버라이딩 되어있더라고 로깅할 때 좋을거 같고 바꾸려고 하는데 어떻게 생각해?

@lee989898 lee989898 merged commit c3f6063 into develop Aug 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ows3090 ows3090 ows3090 approved these changes

@junwooYeom junwooYeom Awaiting requested review from junwooYeom

Assignees

@lee989898 lee989898

Labels
Bug In Progress 준경
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] 케이크샵 불러오기 버그 수정
2 participants
@lee989898 @ows3090