Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added iodine #1277

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added iodine #1277

wants to merge 1 commit into from

Conversation

tihmstar
Copy link
Collaborator

All Submissions

  • Have you made sure there aren't any other open Pull Requests for the same update/change?
  • [!] This Pull Request doesn't contain any package additions; it's a small change (e.g README change)

Package Additions/Updates

  • Have you confirmed this builds & works as intended on an iOS device (if applicable)?
  • [!] Have you confirmed this builds & works as intended on a macOS device (if applicable)?

Compiled iodine for arm64 and tested on iPhone12pro iOS 14.2. Package works as expected

@tihmstar tihmstar requested a review from CRKatri August 28, 2022 09:18
CRKatri
CRKatri requested changes Aug 28, 2022
View reviewed changes
makefiles/iodine.mk
IODINE_VERSION := 7.0-df49fd6
DEB_IODINE_V ?= $(IODINE_VERSION)

IODINE_COMMIT := df49fd6f3d9030662374bfbdcca3e74327084f5e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to calculate the version like https://github.com/ProcursusTeam/Procursus/blob/main/makefiles/libimobiledevice.mk#L7

makefiles/iodine.mk
$(error Use the main Makefile)
endif

SUBPROJECTS += iodine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix alignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CRKatri CRKatri CRKatri requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tihmstar @CRKatri