feat: remove mobile desactivation #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tblivet
commented
Oct 18, 2023
tblivet
commented
| Questions | Answers |
|---|---|
| Description? | I am wondering why this module is disabled by default on mobile device. So I propose to make this module always enable by default, because the merchant is able to disable it on his BO. Moreover, we cannot update this configuration when a theme is installed, that's why I think it's better if the module is enabled on mobile by default what do you think about it ? |
| Type? | improvement / suggestion |
| BC breaks? | no |
| Deprecations? | |
| Fixed ticket? | |
| Sponsor company | @PrestaShopCorp |
| How to test? | You just need to install the module, put your browser in mobile mode, refresh the page and check if the module still shows in mobile. |
No more, this feature has been removed for v9. |
Hlavtox
approved these changes
Oct 18, 2023
|
Thx @Hlavtox I wasn't aware about that 👍 so it makes much more sens if we remove it ! |
|
Hi @tblivet Thank you for your PR, I tested it and it works as you can see : Untitled_.Oct.18.2023.3_40.PM.1.webmThank you |
boherm
approved these changes
Oct 18, 2023
|
PR in accordance with the evolution that PS will have. I'm merging. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.