WebP support #94
WebP support #94
Conversation
patrocle
commented
Aug 17, 2023
•
patrocle
commented
| Questions | Answers |
|---|---|
| Description? | WebP support. WebP lossless images are 26% smaller in size compared to PNGs. WebP lossy images are 25-34% smaller than comparable JPEG |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | |
| Sponsor company | |
| How to test? | Use the module. Upload a new image that uses WebP support. Without this PR, it does not work. |
webp support
There was a problem hiding this comment.
Hello @patrocle !
This is nice, however the current version of ps_imageslider is compatible with PrestaShop 1.7.4.0 until PrestaShop 8.1.0 (here https://github.com/PrestaShop/ps_imageslider/blob/dev/ps_imageslider.php#L65)
WebP image support has been added in PrestaShop 8.0.0 (see PrestaShop/PrestaShop#10356).
So if someone uses this PR on PrestaShop 1.7.8 for example it will not work.
I suggest that, in this PR, you modify the minimum version of PrestaShop compatible with ps_imageslider to 8.0.0 😉
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/[email protected] | ||
|
|
||
| - name: PHP syntax checker 5.6 |
There was a problem hiding this comment.
@patrocle I think it would be better to keep PHP checks for 7.2 to 8.1. As you probably know, PrestaShop 8.0 is compatible with PHP 7.2 to 8.1.
|
Hey @patrocle Thanks for your contribution! A couple of suggestions:
|
… PrestaShop compatibility 8.0.0 and 8.1.0
| @@ -58,12 +50,12 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| presta-versions: ['1.7.4.4', '1.7.5.1', '1.7.6', '1.7.7', '1.7.8', 'latest'] | |||
| presta-versions: ['8.0.0', '8.1.0', 'latest'] | |||
There was a problem hiding this comment.
I guess we should use '8.0', '8.1' here (they mean 8.0.x and 8.1.x :)
| @@ -35,7 +27,7 @@ jobs: | |||
| - name: Setup PHP | |||
| uses: shivammathur/setup-php@v2 | |||
| with: | |||
| php-version: '7.4' | |||
| php-version: '8.1' | |||
There was a problem hiding this comment.
I'm confused about the impact of this php-version change 😕
| @@ -62,7 +62,7 @@ public function __construct() | |||
|
|
|||
| $this->displayName = $this->trans('Image slider', [], 'Modules.Imageslider.Admin'); | |||
| $this->description = $this->trans('Add sliding images to your homepage to welcome your visitors in a visual and friendly way.', [], 'Modules.Imageslider.Admin'); | |||
| $this->ps_versions_compliancy = ['min' => '1.7.4.0', 'max' => _PS_VERSION_]; | |||
| $this->ps_versions_compliancy = ['min' => '8.0.0', 'max' => _PS_VERSION_]; | |||
There was a problem hiding this comment.
module version need to be bumped to 4.0.0 accordingly
|
My ps_imageslider v3.1.4 doesn't seem to accept .webp source images even though other settings are configured correctly and products, categories, etc. have .webp source images that also render as such. PrestaShop v8.1.4
EDIT: works after manually applying the fix from @matks |
Did you just change the 'min' value on $this->ps_versions_compliancy to a value of '8.0.0'? I'm having the same problem on the latest Prestashop 8.1.7 and that sadly didn't work for me. |
|
Hi folks, do we know around when it will be compatible? With latest version 3.2.1 under Prestashop 8.2, it doesn't look to be compatible. |
|
Hello, what changes are required ? |
