Fix sorting of slides #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hlavtox
commented
Sep 25, 2024
Hlavtox
commented
| Questions | Answers |
|---|---|
| Description? | Sorting worked only for single digit IDs. :-))) It's now fixed. |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes PrestaShop/PrestaShop#37027 |
| Sponsor company | TRENDO s.r.o. |
| How to test? | Create more than 10 slides and try to sort them. |
2 tasks
ShaiMagal
approved these changes
Sep 25, 2024
|
Tested on a client with more than 20 slides, works properly. ✅ sorting.mp4 |
florine2623
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Hello @Hlavtox ,
Thanks for the PR !
Update to v3.2.1 successful ✅
Tested with less than 10 sliders images.
Tested with 15 sliders images.
Checked the sliders enabled, disabled.
Checked in FO if the sorting is taken into account.
Drag and dropped sliders in many places.
LGTM, it is QA ✅
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.