Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct instruction link for .env file #610

Merged

Conversation

leemyongpakva
Copy link
Contributor

Questions Answers
Description? Correct instruction link for .env file, please check detail in related issue.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #580
Sponsor company Your company or customer's name goes here (if applicable).
How to test? Just open the current link and the new one, and see which contains relevant instruction.

@leemyongpakva leemyongpakva requested a review from kpodemski March 19, 2024 03:31
@leemyongpakva leemyongpakva added this to the Beta milestone Mar 19, 2024
Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @leemyongpakva ,

Thanks for the PR. The link is correct !

Before :
Screenshot 2024-03-19 at 15 28 03

After :
Screenshot 2024-03-19 at 15 31 05

LGTM. It is QA ✅

@matthieu-rolland matthieu-rolland merged commit 06ff161 into PrestaShop:develop Mar 19, 2024
6 checks passed
@matthieu-rolland
Copy link
Contributor

thank you @leemyongpakva and @florine2623 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Build command fails if there is no .env file with a wrong message
5 participants