-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: issue 37194 #157
Fix: issue 37194 #157
Conversation
tblivet
commented
Oct 21, 2024
Questions | Answers |
---|---|
Description? | Fix issue PrestaShop/PrestaShop#37194 |
Type? | bug fix |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | PrestaShop/PrestaShop#37194 |
Sponsor company | @PrestaShopCorp |
How to test? | Test is describe in the issue PrestaShop/PrestaShop#37194 |
Hello @tblivet! This is your first pull request on classic-theme repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @tblivet ,
I tested with 8.2.x and 9.0.x, I don't have the expected behavior.
Before, the text was displayed (even if misaligned), but with the PR, the text is never displayed.
Before :
Screen.Recording.2024-10-22.at.13.53.58.mov
After :
Screen.Recording.2024-10-22.at.13.55.12.mov
Am I missing something ?
Thanks!
Hello @florine2623 👋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tblivet for the details.
I have retested it and it works as expected :
Screen.Recording.2024-10-22.at.14.19.03.mov
It is QA ✅ !
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
@tblivet thanks :) |