Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: issue 37194 #157

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Fix: issue 37194 #157

merged 2 commits into from
Oct 22, 2024

Conversation

tblivet
Copy link

@tblivet tblivet commented Oct 21, 2024

Questions Answers
Description? Fix issue PrestaShop/PrestaShop#37194
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? PrestaShop/PrestaShop#37194
Sponsor company @PrestaShopCorp
How to test? Test is describe in the issue PrestaShop/PrestaShop#37194

@ps-jarvis
Copy link

Hello @tblivet!

This is your first pull request on classic-theme repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

@ps-jarvis ps-jarvis added the Waiting for QA Status: Waiting for QA feedback label Oct 21, 2024
@florine2623 florine2623 self-assigned this Oct 22, 2024
Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tblivet ,

I tested with 8.2.x and 9.0.x, I don't have the expected behavior.

Before, the text was displayed (even if misaligned), but with the PR, the text is never displayed.

Before :

Screen.Recording.2024-10-22.at.13.53.58.mov

After :

Screen.Recording.2024-10-22.at.13.55.12.mov

Am I missing something ?
Thanks!

@tblivet
Copy link
Author

tblivet commented Oct 22, 2024

Hello @florine2623 👋
After executing the code in the console, you can click on the other carrier to display the extra content, and it should work as expected.
However, the content added by the code in the console does not reflect the real behavior of this block. The content is tested directly in the code, and if the extra content is not empty, the block will be displayed by default.

Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tblivet for the details.

I have retested it and it works as expected :

Screen.Recording.2024-10-22.at.14.19.03.mov

It is QA ✅ !

@florine2623 florine2623 added QA ✔️ Status: QA-Approved and removed Waiting for QA Status: Waiting for QA feedback labels Oct 22, 2024
@ga-devfront ga-devfront merged commit a6b9f7c into PrestaShop:2.1.x Oct 22, 2024
4 checks passed
@ps-jarvis
Copy link

PR merged, well done!

Message to @PrestaShop/committers: do not forget to milestone it before the merge.

@tblivet tblivet deleted the fix/issue-37194 branch October 22, 2024 12:22
@ShaiMagal
Copy link

@tblivet thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA ✔️ Status: QA-Approved
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Missing/Incorrect CSS for div "carrier-extra-content" - hook "displayCarrierExtraContent"
5 participants