Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Updating worker guide for new deployment patterns plus small warnings added to avoid common snags #300

Merged
merged 10 commits into from
Aug 1, 2023

Conversation

taylor-curran
Copy link
Contributor

@taylor-curran taylor-curran commented Jul 31, 2023

This PR updates the worker guide to accommodate certain snags i recently hit while ECS devving + it updates the content to reflect the new deployment patterns exiting beta and the new tutorials that have been written in the main docs.

Example

Screenshots

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

@taylor-curran taylor-curran marked this pull request as ready for review July 31, 2023 15:33
@taylor-curran taylor-curran requested a review from a team as a code owner July 31, 2023 15:33
@taylor-curran taylor-curran changed the title Tay worker guide Updating worker guide for new deployment patterns plus small warnings added to avoid common snags Jul 31, 2023
Copy link
Contributor

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! just a couple nits

docs/ecs_guide.md Outdated Show resolved Hide resolved
docs/ecs_guide.md Outdated Show resolved Hide resolved
docs/ecs_guide.md Outdated Show resolved Hide resolved
docs/ecs_guide.md Show resolved Hide resolved
Copy link
Contributor

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - please update the PR body before merging

@zzstoatzz zzstoatzz merged commit 68daa72 into PrefectHQ:main Aug 1, 2023
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants