Biomass_core.Rmd -> module manual. #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 34b0f39.
eliotmcintire
approved these changes
Feb 23, 2022
achubaty
approved these changes
Feb 23, 2022
added 8 commits
February 23, 2022 10:08
* re-knit, TEST OK
ianmseddy
requested changes
Feb 23, 2022
Biomass_core.R
Outdated
| @@ -873,8 +896,8 @@ Init <- function(sim, verbose = getOption("LandR.verbose", TRUE)) { | |||
| maxBiomass <- maxValue(sim$biomassMap) | |||
| if (maxBiomass < 1e3) { | |||
| if (verbose > 0) { | |||
| message(crayon::green(" Because biomassMap values are all below 1000, assuming that these should be\n", | |||
| " converted to tonnes/ha by multiplying by 100")) | |||
| message(crayon::green(" Because biomassMap values are all below 1000, assuming that these are on ton/ha.\n", | |||
There was a problem hiding this comment.
can we change ton/ha to Mg/ha (or at least tonne/ha)?
There was a problem hiding this comment.
actually we use tonnes/ha below this, so if we use Mg we should update both instances.
Biomass_core.R
Outdated
| expectsInput("species", "data.table", | ||
| desc = paste("a table that has species traits such as longevity, shade tolerance, etc.", | ||
| "Default is partially based on Dominic Cir and Yan's project"), | ||
| "Default is partially based on Dominic Cir and Yan Boulanger's project"), |
There was a problem hiding this comment.
I believe it's Dominic Cyr, not Cir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*TO DO: