Add xmlid_root option for braille conversion #2365
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarlevin
force-pushed
the
xmlid-root-braille
branch
from
d8384b5 to
059c565
Compare
|
Upon closer inspection, I think more work needs to be done, specifically in the xsl. Converting to draft for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davidaustinm noted that building a braille book especially could benefit from restricting to just a chapter. This adds that option in the same way that the xmlid_root is done in the other conversions.
Note, I have not tested that this actually works with the rest of the braille conversion. Understand it might take a while to get this merged.