-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick dirty html build #2329
base: master
Are you sure you want to change the base?
Quick dirty html build #2329
Conversation
@rbeezer @oscarlevin Our discussion in drop in mostly assumed quick and dirty would in fact be dirty. Since it is cleaner than expected, it might make sense to always enable it when For the CLI, the case seems stronger to make building a subset always use quick and dirty. Possibly with an opt-out switch and a message that subset building is not guaranteed to be artifact free. |
Kind of jumping in to the middle here, but I'm seeing a potential use case on Runestone. An instructor types in a question in PreTeXt, we take the PreTeXt and add it to a mimimal book, where we then build the subset of that book containing this one exercise. Looks like it could be quite fast! Then we extract the generated html to preview and save to the DB. This is essentially what we do today, but I think we could do it with the cli and not have to spin up another process. |
520711f
to
1a31af3
Compare
Rebased and updated against master post @rbeezer update to Runestone logic. Retested. |
1a31af3
to
58eaee9
Compare
Force push after rebase on current master |
I rebased this code off of #2328 as the logic re: runestone-services overlaps and that other PR seems more fundamental.
This adds
html.quick-dirty
string param. It cuts out build steps when used on its own. When used with-r
it prunes the source tree early in the assembly phase and really shines.The results are not all that dirty... quick and dirty produces clean diffs.