Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable cmake policy that removes FindBoost.cmake #873

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Jan 15, 2025

Workaround for compatibility with CMake >= 3.30 due to https://cmake.org/cmake/help/latest/policy/CMP0167.html#policy:CMP0167

Depending on the outcome of conda-forge/boost-feedstock#226 and when CMake actually removes the deprecated functionality, we may need to move to libboost-devel for Windows instead in the future.

@mgovers mgovers added the dependencies Pull requests that update a dependency file label Jan 15, 2025
@mgovers mgovers requested a review from TonyXiang8787 January 15, 2025 13:24
@mgovers mgovers self-assigned this Jan 15, 2025
@mgovers
Copy link
Member Author

mgovers commented Jan 15, 2025

discussion for sustainable fix in conda-forge/boost-feedstock#226

@TonyXiang8787 TonyXiang8787 added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 349a000 Jan 16, 2025
28 checks passed
@TonyXiang8787 TonyXiang8787 deleted the feature/cmake-3-30-compatibility branch January 16, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants