Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add columnar data to data types (but don't use yet) #663

Merged
merged 12 commits into from
Aug 21, 2024
Merged

add columnar data to data types (but don't use yet) #663

merged 12 commits into from
Aug 21, 2024

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Jul 5, 2024

@mgovers mgovers added the feature New feature or request label Jul 5, 2024
@mgovers
add columnar data to data types
5467c88 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers mgovers force-pushed the feature/columnar-dataset-python-api branch from 3330277 to 5467c88 Compare July 5, 2024 07:51
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 5, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo mentioned this pull request Jul 22, 2024
Merged
@mgovers mgovers mentioned this pull request Jul 31, 2024
Merged
@figueroa1395
Copy link
Contributor

As a side note. Before merging (After Python API is ready), this PR should be updated to be compliant with #680 and part 2 (to be done) of #465.

@mgovers mgovers mentioned this pull request Aug 13, 2024
Merged
@mgovers mgovers changed the base branch from main to feature/typevar-implementation August 13, 2024 12:03
mgovers added 6 commits August 13, 2024 14:20
@mgovers
Merge remote-tracking branch 'origin/feature/typevar-implementation' …
0a47dca 
…into feature/columnar-dataset-python-api

Signed-off-by: Martijn Govers <[email protected]>
@mgovers
Merge remote-tracking branch 'origin/feature/typevar-implementation' …
231f406 
…into feature/columnar-dataset-python-api

Signed-off-by: Martijn Govers <[email protected]>
@mgovers
Merge remote-tracking branch 'origin/feature/typevar-implementation' …
8c9b063 
…into feature/columnar-dataset-python-api

Signed-off-by: Martijn Govers <[email protected]>
@mgovers
Merge remote-tracking branch 'origin/feature/typevar-implementation' …
7385ac7 
…into feature/columnar-dataset-python-api

Signed-off-by: Martijn Govers <[email protected]>
@mgovers
resolve comments
6a959af 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
update dataset type hierarchy
b7da914 
Signed-off-by: Martijn Govers <[email protected]>
Base automatically changed from feature/typevar-implementation to main August 15, 2024 07:09
@mgovers mgovers marked this pull request as ready for review August 16, 2024 10:37
figueroa1395
figueroa1395 reviewed Aug 16, 2024
View reviewed changes
src/power_grid_model/core/buffer_handling.py Show resolved Hide resolved
src/power_grid_model/core/buffer_handling.py Show resolved Hide resolved
src/power_grid_model/core/buffer_handling.py Show resolved Hide resolved
src/power_grid_model/core/serialization.py Show resolved Hide resolved
src/power_grid_model/data_types.py Outdated Show resolved Hide resolved
src/power_grid_model/data_types.py Show resolved Hide resolved
src/power_grid_model/data_types.py Show resolved Hide resolved
src/power_grid_model/data_types.py Show resolved Hide resolved
src/power_grid_model/data_types.py Outdated Show resolved Hide resolved
src/power_grid_model/data_types.py Outdated Show resolved Hide resolved
@mgovers
resolve comments
7f7fef4 
Signed-off-by: Martijn Govers <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

figueroa1395
figueroa1395 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@figueroa1395 figueroa1395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mgovers mgovers added this pull request to the merge queue Aug 21, 2024
@mgovers mgovers mentioned this pull request Aug 21, 2024
Merged
1 task
Merged via the queue into main with commit 8256ecc Aug 21, 2024
26 checks passed
@mgovers mgovers deleted the feature/columnar-dataset-python-api branch August 21, 2024 13:17
@mgovers mgovers mentioned this pull request Nov 5, 2024
Closed
27 tasks
@figueroa1395 figueroa1395 mentioned this pull request Nov 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitbharambe nitbharambe nitbharambe left review comments

@figueroa1395 figueroa1395 figueroa1395 approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgovers @figueroa1395 @nitbharambe