Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test and luacheck workflows in GH actions #2

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

rgacogne
Copy link
Member

The test workflow is currently more limited than the existing one that used Travis CI and tested various versions of Lua, but at least it works and will be executed for all pushed commits and pull requests from now on.

The workflow is currently more limited than the existing one that
used Travis CI and tested various versions of Lua, but at least it
works and will be executed for all pushed commits and pull requests
from now on.
@rgacogne rgacogne added the enhancement New feature or request label Sep 27, 2024
@rgacogne rgacogne requested a review from Habbie September 27, 2024 13:47

jobs:
luacheck:
runs-on: ubuntu-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always have mixed feelings on -latest. It's nice to run latest, but sometimes it gives you an annoying surprise. No specific opinion either way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll stick with -latest for now, and will likely reconsider if/when I get burned :)

@rgacogne rgacogne merged commit 0208a84 into master Sep 30, 2024
4 checks passed
@rgacogne rgacogne deleted the gh-actions branch September 30, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants