Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: minimum CI Go version 1.22 to fix error #37

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

wojas
Copy link
Member

@wojas wojas commented Dec 20, 2024

This failure occurs with older versions.

Run go install golang.org/x/tools/cmd/goimports@latest
go: downloading golang.org/x/tools v0.28.0
go: golang.org/x/tools/cmd/goimports@latest (in golang.org/x/[email protected]): go.mod:3: invalid go version '1.22.0': must match format 1.23

Dropping older versions from CI is consistent with the Go support policy of only supporting the last two versions, but unfortunate.

Closes #36

This failure occurs with older versions.

    Run go install golang.org/x/tools/cmd/goimports@latest
    go: downloading golang.org/x/tools v0.28.0
    go: golang.org/x/tools/cmd/goimports@latest (in golang.org/x/[email protected]): go.mod:3: invalid go version '1.22.0': must match format 1.23

Dropping older versions from CI is consistent with the Go support
policy of only supporting the last two versions, but unfortunate.
@wojas wojas added this to the v1.9.3 milestone Dec 20, 2024
@johanlantz
Copy link

LGTM

@wojas wojas merged commit de39dd9 into PowerDNS:master Jan 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Fix goimports 'invalid go version' error
2 participants