Go tests: run in Github Actions, and make the sync tests reliable #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly pass the lmdb.Env to the syncer, so that we have more control over its lifetime and avoid opening and closing it multiple times, which can cause crashes in the LMDB C code. Rewrite the sync tests to wait for expected values, instead of relying on arbitrary sleeps that make the test flaky and slow. Do not close the lmdb.Env in the sync tests, because for some reason it causes random SEGFAULTs on Linux (not on macOS).
wojas
changed the title
|
Good changes & nice to have the tests included. Only concern is the S3 testing, which is skipped: Perhaps not suitable for this PR, but for a future improvement: Can we have the GH Action prep a minio server to allow for the tests to also include the S3-backed usecases? |
nvaatstra
approved these changes
Mar 21, 2023
Good point, added #36 for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run Go tests in Github Actions.
To make the tests pass consistently:
Explicitly pass the lmdb.Env to the syncer, so that we have more control
over its lifetime and avoid opening and closing it multiple times, which
can cause crashes in the LMDB C code.
Rewrite the sync tests to wait for expected values, instead of relying
on arbitrary sleeps that make the test flaky and slow.
Do not close the lmdb.Env in the sync tests, because for some reason it
causes random SEGFAULTs on Linux (not on macOS).
Upgrade golangci-lint for Go 1.20