Add TACACS Server configuration (Add/Get/Set/Remove) #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alagoutte
changed the title
alagoutte
requested changes
Nov 30, 2021
PowerArubaCX/Public/Tacacs.ps1
Outdated
|
|
||
| <# | ||
| .SYNOPSIS | ||
| Add Aruba CX Tacacs Server |
There was a problem hiding this comment.
Tacacs => TACACS (for other after too)
PowerArubaCX/Public/Tacacs.ps1
Outdated
| [string]$auth_type = "pap", | ||
| [Parameter (Mandatory = $true)] | ||
| [ValidateRange(1, 9223372036854775807)] | ||
| [int]$default_group_priority, |
There was a problem hiding this comment.
int64 ? (for validateRange)
alagoutte
requested changes
Nov 30, 2021
PowerArubaCX/Public/Tacacs.ps1
Outdated
| Configure TACACS Server (Timeout, port...) | ||
|
|
||
| .EXAMPLE | ||
| Set-ArubaCXTacacsServer -timeout 15 -address 192.2.0.1 -port 49 |
There was a problem hiding this comment.
All example with Pipeline ?
|
|
||
| $_group = @() | ||
|
|
||
| $_group += "/rest/" + $($connection.version) + "/system/aaa_server_groups/" + $group |
There was a problem hiding this comment.
always needed to be update ?
PowerArubaCX/Public/Tacacs.ps1
Outdated
|
|
||
| if ($PSCmdlet.ShouldProcess("Tacacs Server (VRF: ${vrf})", "Remove ${address},${port}")) { | ||
| Invoke-ArubaCXRestMethod -method "DELETE" -uri $uri -connection $connection | ||
| Write-Progress -activity "Remove Tacacs Server" -completed |
There was a problem hiding this comment.
remove this write-progress too
Tests/integration/Tacacs.Tests.ps1
Outdated
| . ../common.ps1 | ||
|
|
||
| Describe "Get TACACS Server" { | ||
| BeforeALL { |
Tests/integration/Tacacs.Tests.ps1
Outdated
|
|
||
| It "Get TACACS Server with one attribute (auth_type)" { | ||
| $tacacs = Get-ArubaCXTacacsServer -address $pester_tacacs_address -port $pester_tacacs_port -attribute auth_type | ||
| @($tacacs).count | Should -be 1 |
There was a problem hiding this comment.
-be -> -Be (same issue after)
alagoutte
reviewed
Dec 27, 2021
| [Parameter(Mandatory = $false)] | ||
| [ValidateRange(1, 4)] | ||
| [Int]$depth, | ||
| [Parameter(Mandatory = $false, ParameterSetName = "address")] |
alagoutte
reviewed
Dec 27, 2021
| [Parameter (Mandatory = $true, ParameterSetName = "address")] | ||
| [ipaddress]$address, | ||
| [Parameter (Mandatory = $false)] | ||
| [int]$port = 49, |
There was a problem hiding this comment.
missing parameter set name for port ?
alagoutte
reviewed
Dec 27, 2021
| [CmdletBinding(DefaultParametersetname = "Default")] | ||
| Param( | ||
| [Parameter (Mandatory = $true, ParameterSetName = "address")] | ||
| [ipaddress]$address, |
There was a problem hiding this comment.
TACACS can't be a FQDN ?
alagoutte
reviewed
Dec 27, 2021
|
|
||
| $uri = "system/vrfs/${vrf}/tacacs_servers/${address},${port}" | ||
|
|
||
| if ($PSCmdlet.ShouldProcess("Tacacs Server (VRF: ${vrf})", "Remove ${address},${port}")) { |
alagoutte
reviewed
Dec 27, 2021
alagoutte
reviewed
Dec 27, 2021
| Get-ArubaCXTacacsServer -address 192.2.0.1 | Remove-ArubaCXTacacsServer | ||
| ``` | ||
|
|
||
| For configure a vlan to an interface, need to use [Set-ArubaCXInterfaces](#Interface) |
alagoutte
requested changes
Dec 27, 2021
alagoutte
reviewed
Jan 24, 2022
| } | ||
| } | ||
|
|
||
| $response = Invoke-ArubaCXRestMethod -uri $uri -method 'POST' -body $_tacacs -connection $connection |
alagoutte
reviewed
Jan 24, 2022
|
|
||
|
|
||
| # Remove a TACACS Server | ||
| Get-ArubaCXTacacsServer -address 192.2.0.1 | Remove-ArubaCXTacacsServer |
There was a problem hiding this comment.
add example of remove...
alagoutte
reviewed
Jan 24, 2022
| @@ -13,6 +13,8 @@ $script:pester_interface2 = "1/1/2" #interface id for test... | |||
| $script:pester_lag = "2" #lag id for test... | |||
| $script:pester_loopback = "2" #loopback id for test... | |||
| $script:pester_vrf = "pester_vrf" #interface id for test... | |||
| $script:pester_tacacs_address = "192.2.0.1" | |||
There was a problem hiding this comment.
it is 192.0.2.0/24 for example network
alagoutte
reviewed
Jan 24, 2022
| @@ -0,0 +1,227 @@ | |||
| # | |||
| # Copyright 2020, Cédric Moreau <moreaucedric0 at gmail dot com> | |||
alagoutte
reviewed
Jan 24, 2022
|
|
||
| Context "Search" { | ||
| It "Search TACACS Server by address ($pester_tacacs_address)" { | ||
| $tacacs = Get-ArubaCXTacacsServer -address $pester_tacacs_address -port $pester_tacacs_port |
There was a problem hiding this comment.
add search without port
and also with position = 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.