force UseAffectedRows=false. fixes #93 (#100)

PomeloFoundation · Oct 29, 2016 · 3b60071 · 3b60071
1 parent 6fdc071
commit 3b60071
Show file tree

Hide file tree

Showing 4 changed files with 39 additions and 4 deletions.
diff --git a/src/Pomelo.EntityFrameworkCore.MySql/Extensions/MySqlDbContextOptionsExtensions.cs b/src/Pomelo.EntityFrameworkCore.MySql/Extensions/MySqlDbContextOptionsExtensions.cs
@@ -24,7 +24,8 @@ public static DbContextOptionsBuilder UseMySql(
 
             var csb = new MySqlConnectionStringBuilder(connectionString)
             {
-                AllowUserVariables = true
+	            AllowUserVariables = true,
+	            UseAffectedRows = false
             };
             connectionString = csb.ConnectionString;
 
@@ -47,7 +48,8 @@ public static DbContextOptionsBuilder UseMySql(
 
             var csb = new MySqlConnectionStringBuilder(connection.ConnectionString)
             {
-                AllowUserVariables = true
+	            AllowUserVariables = true,
+	            UseAffectedRows = false
             };
 
             connection.ConnectionString = csb.ConnectionString;

diff --git a/src/Pomelo.EntityFrameworkCore.MySql/project.json b/src/Pomelo.EntityFrameworkCore.MySql/project.json
@@ -20,7 +20,7 @@
 
   "dependencies": {
     "Microsoft.EntityFrameworkCore.Relational": "1.0.1",
-    "MySqlConnector": "0.6.0-*",
+    "MySqlConnector": "0.6.*",
     "Pomelo.JsonObject": "1.0.0-*"
   },
 

diff --git a/test/Pomelo.EntityFrameworkCore.MySql.PerfTests/Tests/Connection/ConnectionTest.cs b/test/Pomelo.EntityFrameworkCore.MySql.PerfTests/Tests/Connection/ConnectionTest.cs
@@ -0,0 +1,33 @@
+using System.Threading.Tasks;
+using Pomelo.EntityFrameworkCore.MySql.PerfTests.Models;
+using Xunit;
+
+namespace Pomelo.EntityFrameworkCore.MySql.PerfTests.Tests.Connection
+{
+	public class ConnectionTest
+	{
+
+		[Fact]
+		public async Task AffectedRowsFalse()
+		{
+			var title = "test";
+			var blog = new Blog{ Title = title };
+			using (var db = new AppDb())
+			{
+				db.Blogs.Add(blog);
+				await db.SaveChangesAsync();
+			}
+			Assert.True(blog.Id > 0);
+
+			// this will throw a DbUpdateConcurrencyException if UseAffectedRows=true
+			var sameBlog = new Blog { Id = blog.Id, Title = title };
+			using (var db = new AppDb())
+			{
+				db.Blogs.Update(sameBlog);
+				await db.SaveChangesAsync();
+			}
+			Assert.Equal(blog.Id, sameBlog.Id);
+		}
+
+	}
+}
diff --git a/test/Pomelo.EntityFrameworkCore.MySql.Tests/MysqlRelationalConnectionTest.cs b/test/Pomelo.EntityFrameworkCore.MySql.Tests/MysqlRelationalConnectionTest.cs
@@ -26,7 +26,7 @@ public void Can_create_master_connection_string()
             {
                 using (var master = connection.CreateMasterConnection())
                 {
-                    Assert.Equal(@"Server=localhost;Port=3306;Database=mysql;User Id=root;Password=Password12!;AllowUserVariables=True;Pooling=False", master.ConnectionString);
+                    Assert.Equal(@"Server=localhost;Port=3306;Database=mysql;User Id=root;Password=Password12!;AllowUserVariables=True;Use Affected Rows=False;Pooling=False", master.ConnectionString);
                 }
             }
         }