-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cards from Genetic Apex and some promo cards #554
base: master
Are you sure you want to change the base?
Conversation
Related to #553 |
I've added all missing fields now. |
sets/en.json
Outdated
{ | ||
"id": "tcgp1", | ||
"name": "Genetic Apex", | ||
"series": "TCG Pocket", | ||
"printedTotal": 226, | ||
"total": 286, | ||
"ptcgoCode": "A1" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey man, just asking, is there a reason why you didn't include the releaseDate
and images
properties, that are present in other sets, for the Pocket sets? I'm planning on doing a small personal project related to TCG Pocket using this API, so I'm just wondering if these fields will be available.
Thanks @Joaos98 for pointing that out. Fields are now up to date. |
Thanks for this - going to be reviewing and potentially getting this added in the next week or so. |
@Xernisfy, would you happen to have the newest expansion as well - Mythical Island? |
I scraped Bulbapedia for the new cards from TCG Pocket.
Some props like rarity and artist are missing (because it's tricky to parse), I'll add them as soon as possible.