Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cards from Genetic Apex and some promo cards #554

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Xernisfy
Copy link

@Xernisfy Xernisfy commented Nov 5, 2024

I scraped Bulbapedia for the new cards from TCG Pocket.
Some props like rarity and artist are missing (because it's tricky to parse), I'll add them as soon as possible.

@Xernisfy
Copy link
Author

Xernisfy commented Nov 5, 2024

Related to #553

@Xernisfy
Copy link
Author

Xernisfy commented Nov 6, 2024

I've added all missing fields now.
Please let me know if this is alright or if anything can be improved.
If card images are needed, I can fetch them as well.

sets/en.json Outdated
Comment on lines 2851 to 2858
{
"id": "tcgp1",
"name": "Genetic Apex",
"series": "TCG Pocket",
"printedTotal": 226,
"total": 286,
"ptcgoCode": "A1"
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey man, just asking, is there a reason why you didn't include the releaseDate and images properties, that are present in other sets, for the Pocket sets? I'm planning on doing a small personal project related to TCG Pocket using this API, so I'm just wondering if these fields will be available.

@Xernisfy
Copy link
Author

Thanks @Joaos98 for pointing that out. Fields are now up to date.
I updated my scraping tool to generate the sets/en.json file automatically now.

@adback03
Copy link
Member

Thanks for this - going to be reviewing and potentially getting this added in the next week or so.

@adback03
Copy link
Member

@Xernisfy, would you happen to have the newest expansion as well - Mythical Island?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants