Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: fixes #33 allow to ignore enums by name #90

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

dswistowski
Copy link
Contributor

@dswistowski dswistowski commented Dec 2, 2024

Description

Add ability to ignore process enum by name in similar way alembic allows to define include_name function

Checklist

This pull request is:

  • A documentation / typographical / small typing error fix
    • Good to go, no issue or tests are needed
  • A short code fix
    • please include the issue number, and create an issue if none exists, which
      must include a complete example of the issue. one line code fixes without an
      issue and demonstration will not be accepted.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests. one line code fixes without tests will not be accepted.
  • A new feature implementation
    • please include the issue number, and create an issue if none exists, which must
      include a complete example of how the feature would look.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests.

Have a nice day!

@dswistowski dswistowski changed the title feature: allow to ignore enums by name Fixes: #33 allow to ignore enums by name Dec 2, 2024
@dswistowski dswistowski changed the title Fixes: #33 allow to ignore enums by name feature: fixes #33 allow to ignore enums by name Dec 2, 2024
@RustyGuard
Copy link
Member

Great PR, thank you!
However there is one problem. In situation when include_name returns False for enum that declared in sqlalchemy schema library will attempt to create it even though it may already exist.
Filtering get_declared_enums by include_name should fix this behavior.

@dswistowski
Copy link
Contributor Author

Great PR, thank you! However there is one problem. In situation when include_name returns False for enum that declared in sqlalchemy schema library will attempt to create it even though it may already exist. Filtering get_declared_enums by include_name should fix this behavior.

Done 🍰

@RustyGuard
Copy link
Member

Lint is failing, please rollback changes in run_migration_test_abc.py file. Other than that everything is ok, this PR will be a part of next release

@RustyGuard RustyGuard merged commit 1a5e0c0 into Pogchamp-company:develop Dec 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants