Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "allow" comments #242

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Add "allow" comments #242

merged 2 commits into from
Dec 20, 2024

Conversation

ZedThree
Copy link
Member

Closes #209

Comments are of the form:

! allow(rule)

Usual rule selection applies, list of comma separated selectors

Comments apply to the whole of the next statement, including
constructs, procedures, modules, etc

Needs some proper docs, but I'm not sure where it belongs. Maybe we
need to add a whole tutorial section?

@LiamPattinson
Copy link
Collaborator

Amazing! I was expecting this to be much harder to achieve, and it works great.

I'd be in favour of adding a tutorial to the docs, so I've just raised an issue (#243). For now, perhaps just a section in the README?

Copy link
Collaborator

@LiamPattinson LiamPattinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge, provided a tutorial can be added soon-ish

Closes #209

Comments are of the form:

    ! allow(rule)

Usual rule selection applies, list of comma separated selectors

Comments apply to the whole of the next statement, including
constructs, procedures, modules, etc
Copy link
Collaborator

@LiamPattinson LiamPattinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good!

@LiamPattinson LiamPattinson merged commit 3edd639 into main Dec 20, 2024
25 checks passed
@LiamPattinson LiamPattinson deleted the per-line-ignores branch December 20, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Per-line ignore
2 participants