Skip to content

Commit

Permalink
Loosen requirements for caches in show-repo/plt-version subcmds
Browse files Browse the repository at this point in the history
  • Loading branch information
ethanjli committed Dec 8, 2024
1 parent 16147f6 commit 8e0672b
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 10 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Unreleased

### Fixed

- (cli) `[dev] plt show-plt-version` and `[dev] plt show-repo-version` no longer require the required pallets/repos to be cached before the commands work.

## 0.8.0-alpha.3 - 2024-12-06

### Added
Expand Down
3 changes: 1 addition & 2 deletions cmd/forklift/dev/plt/pallets.go
Original file line number Diff line number Diff line change
Expand Up @@ -489,8 +489,7 @@ func showPltAction(c *cli.Context) error {

func showPltVersionAction(c *cli.Context) error {
plt, caches, err := processFullBaseArgs(c, processingOptions{
requirePalletCache: true,
enableOverrides: true,
enableOverrides: true,
})
if err != nil {
return err
Expand Down
5 changes: 2 additions & 3 deletions cmd/forklift/dev/plt/repositories.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,8 @@ func showRepoAction(c *cli.Context) error {

func showRepoVersionAction(c *cli.Context) error {
plt, caches, err := processFullBaseArgs(c, processingOptions{
requireRepoCache: true,
enableOverrides: true,
merge: true,
enableOverrides: true,
merge: true,
})
if err != nil {
return err
Expand Down
4 changes: 1 addition & 3 deletions cmd/forklift/plt/pallets.go
Original file line number Diff line number Diff line change
Expand Up @@ -992,9 +992,7 @@ func showPltAction(c *cli.Context) error {
// show-plt-version

func showPltVersionAction(c *cli.Context) error {
plt, caches, err := processFullBaseArgs(c.String("workspace"), processingOptions{
requirePalletCache: true,
})
plt, caches, err := processFullBaseArgs(c.String("workspace"), processingOptions{})
if err != nil {
return err
}
Expand Down
3 changes: 1 addition & 2 deletions cmd/forklift/plt/repositories.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,7 @@ func showRepoAction(c *cli.Context) error {

func showRepoVersionAction(c *cli.Context) error {
plt, caches, err := processFullBaseArgs(c.String("workspace"), processingOptions{
requireRepoCache: true,
merge: true,
merge: true,
})
if err != nil {
return err
Expand Down

0 comments on commit 8e0672b

Please sign in to comment.