Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data race between rendering inventory slots and Inventory updates coming from the server #865

Open
IntegratedQuantum opened this issue Dec 31, 2024 · 0 comments
Open

Data race between rendering inventory slots and Inventory updates coming from the server #865

IntegratedQuantum opened this issue Dec 31, 2024 · 0 comments
Labels
bug something isn't working in the intended way engine
Milestone
Short-Term Goals

Comments

@IntegratedQuantum
Copy link
Member

Not a huge deal, but it could crash in rare cases if the item is a tool that got freed in the update.
And of course it clogs up the thread sanitizer output, making it harder to debug other problems.
@IntegratedQuantum IntegratedQuantum added bug something isn't working in the intended way engine labels Dec 31, 2024
@IntegratedQuantum IntegratedQuantum added this to the Long-Term Goals milestone Dec 31, 2024
IntegratedQuantum added a commit that referenced this issue Jan 1, 2025
@IntegratedQuantum
Don't execute empty commands when an item cannot be collected to a gi…
613498d 
…ven item stack.

fixes #871 (technically it fixes only the symptoms, not the root cause. The root cause is probably #865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something isn't working in the intended way engine
Projects
None yet
Milestone
Short-Term Goals
Development

No branches or pull requests
1 participant
@IntegratedQuantum