Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronization functions are now thread pool specific #43

Closed
wants to merge 1 commit into from

Conversation

marwankallal
Copy link
Contributor

Instead of using pthread_kill() to send signals, we can use pthread_sigqueue() to pass a pointer of the pausing threadpool to the signal handler. From there, I've kept the previous sleep(1) loop to wait for thpool_resume()

(fix for #13)

@Pithikos
Copy link
Owner

Pithikos commented Oct 9, 2016

Thanks for the work! I did try the fix and it seems to work. The only annoying thing is the warnings during compilation and as I found out this works only if we include #define _GNU_SOURCE in the top of the source code which unfortunately means that the code stops being POSIX compliant.

You think there is a way to rework this implementation to not deviate from the POSIX standard?

@marwankallal
Copy link
Contributor Author

That is true, I'll try to find a POSIX compliant way and add it to this PR.

@Pithikos
Copy link
Owner

I close this since there are not any new updates. Feel free to re-open if anything changes.

@Pithikos Pithikos closed this Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants