Add generic rule: models should implement uniqueness test for their PK #90
+48
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieucan
requested review from
michael-the1,
jochemvandooren and
druzhinin-kirill
Comment on lines
+58
to
+59
| if model.config.get("materialized") not in {"table", "incremental"}: | ||
| return None |
There was a problem hiding this comment.
Would you like us to implement this with a rule filter? Maybe even the whole pk discovery can be a filter, and this filter can be also part of the public dbt-score API on par with default rules 🤔
So people who implement their own rules for pk'ed tables but use the same filter implementation💡
| return None | ||
|
|
||
| # Extract PK | ||
| pk_columns = None |
There was a problem hiding this comment.
Can it be an empty list, and we only verify pk_columns if the length is >0 (=1)?
I think this way we can ensure pk_columns is always a list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For models materialized as
tableorincremental:Consider both table- and column-level constraints and tests.