Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realtime export of payload data in KML format. #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fab4space
Copy link

This new feature enabled by EnableKML=Y in gateway.txt allow to export in a KML file .kml for each payload, updating in realtime the position in the track of the kml. A -refresh.kml is also automatically created for viewing in realtime the updated positions from google earth.
This feature will be used in the chasecar when the internet connection is lost and will allow to have the payload position on a map even without internet connection.

@@ -604,6 +606,8 @@ void LoadConfigFile()
ReadString(fp, "ftpPassword", Config.ftpPassword, sizeof(Config.ftpPassword), 0);
ReadString(fp, "ftpFolder", Config.ftpFolder, sizeof(Config.ftpFolder), 0);

ReadBoolean(fp, "EnableKML", 0, &Config.EnableKML);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don`t make this a boolean. I would like to add different log levels, to record full telemetry and/or KML and/or RSSI / frequency offset etc. Perhaps change the name to "LogLevel" and use a bitmask. Thanks.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This configuration entry is only for enabling KML output (like Habitat output which is a boolean too), and in this current changeset the data which is exported in the kml is not configurable (lat,lon and altitude). When new features for kml export will be implemented I suggest that we add configuration variable for these features, but since we don't know what may be supported in the future I suggest that we don't add configuration entries which are not supported. It would be nice to implement logging with the features you mentioned but this is out of scope of this kml feature.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that an EnableKML bolean seems consistent with the other features and perhaps LogTelemetry/LogKML/LogRSSI boleans if/when the ability to log these values is added in future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants