Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add background fade to the opening and dismissing animation #30

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Add background fade to the opening and dismissing animation #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
b5d9948
Add background fade to the dismiss animation
chickdan May 16, 2018
0caf4b9
Updating the background to also fade in instead of appearing instantly.
chickdan Jul 14, 2018
d13cf5a
Convert to Swift 5
chickdan Nov 12, 2021
3eeed63
Clean up MARKs for minimap
chickdan Nov 12, 2021
417609b
Remove some force unwraps
chickdan Nov 12, 2021
78ac53a
Remove more force unwrapping and unnecessary use of self
chickdan Nov 12, 2021
3f2fbe7
Remove force unwrapping of index
chickdan Nov 12, 2021
3f176ae
Removing more force unwraps and unnecessary use of self
chickdan Nov 12, 2021
895f568
Fix retain cycles and split out dispatch queue to function
chickdan Nov 12, 2021
175c080
Remove unnecessary use of self
chickdan Nov 12, 2021
1819b79
Fix another retain cycle
chickdan Nov 12, 2021
2010270
refactor
chickdan Nov 30, 2021
1dbd74d
Make page control a computed property
chickdan Sep 4, 2022
4ccd5ec
Remove unnecessary use of self
chickdan Sep 4, 2022
858cfb1
cleanup and improvements
chickdan Sep 4, 2022
790566d
Use guard instead of force unwrapping
chickdan Sep 5, 2022
8f4495a
Run SwiftLint
chickdan Sep 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions AlertOnboarding.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@
TargetAttributes = {
37845A641D994CBA009B3734 = {
CreatedOnToolsVersion = 8.0;
LastSwiftMigration = 1240;
ProvisioningStyle = Automatic;
};
};
Expand All @@ -125,6 +126,7 @@
developmentRegion = English;
hasScannedForEncodings = 0;
knownRegions = (
English,
en,
Base,
);
Expand Down Expand Up @@ -291,7 +293,7 @@
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = com.cookminute.AlertOnboarding;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_VERSION = 4.0;
SWIFT_VERSION = 5.0;
};
name = Debug;
};
Expand All @@ -304,7 +306,7 @@
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = com.cookminute.AlertOnboarding;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_VERSION = 4.0;
SWIFT_VERSION = 5.0;
};
name = Release;
};
Expand Down
10 changes: 5 additions & 5 deletions AlertOnboarding/AlertChildPageViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,17 @@
import UIKit

class AlertChildPageViewController: UIViewController {
var pageIndex: Int!

var pageIndex: Int = 0

@IBOutlet weak var image: UIImageView!
@IBOutlet weak var labelMainTitle: UILabel!
@IBOutlet weak var labelDescription: UILabel!

override func viewDidLoad() {
super.viewDidLoad()
}

override func didReceiveMemoryWarning() {
super.didReceiveMemoryWarning()
}
Expand Down
Loading