Fix mtime dates #101
Merged
Fix mtime dates #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a mistake in how we were calculating mtime -- the `getTime` method returns milliseconds but it's expected to be passed in terms of seconds. Nothing a simple division by 1000 can't fix!
The archive folders and archive root folders were populating with "default" dates rather than dates driven by the archive / folder values. This was resulting in unix epoch values. Issue #98
nfebe
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few bugs related to the reported mtimes for files and folders. In particular it now properly uses seconds (instead of ms) when reporting the dates. It also uses the archive data for archive folders.
It does not address the
/archivesfolder, which does not actually exist in permanent and should likely be linked to the user's account creation date, but I'd like to address that as part of #100Note this can be tested locally using the
rclone lsjsoncommand which will show the mtimes associated with various items in a path.Resolves #98