Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance/new data manager #203

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Performance/new data manager #203

merged 6 commits into from
Oct 1, 2024

Conversation

JTHesse
Copy link
Collaborator

@JTHesse JTHesse commented Oct 1, 2024

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a unit and/or fullscale test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure unit and fullscale tests pass.
  • DO make sure not to introduce any compiler warnings.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to PeriLab's overall architecture.

@JTHesse JTHesse merged commit 7901935 into main Oct 1, 2024
2 checks passed
@JTHesse JTHesse deleted the performance/new_data_manager branch October 1, 2024 14:23
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 95.48023% with 8 lines in your changes missing coverage. Please review.

Project coverage is 83.96%. Comparing base (7304cea) to head (d2823e7).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/Core/data_manager.jl 95.45% 7 Missing ⚠️
src/Support/helpers.jl 90.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
+ Coverage   83.52%   83.96%   +0.43%     
==========================================
  Files          74       74              
  Lines        5682     5594      -88     
==========================================
- Hits         4746     4697      -49     
+ Misses        936      897      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants