Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge tfiedor aka the Perfexionists coup d'etat #146

Conversation

HarryMichal
Copy link
Contributor

@HarryMichal HarryMichal commented Nov 27, 2023

:)

Grepping for tfiedor returns no hits after this.

Continuation of a2ef53b

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f3c99b5) 98.61% compared to head (9583551) 98.61%.
Report is 1 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel     #146   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files         130      130           
  Lines        8594     8594           
=======================================
  Hits         8475     8475           
  Misses        119      119           
Flag Coverage Δ
coverage-3.10 98.59% <ø> (ø)
coverage-3.11 98.52% <ø> (-0.04%) ⬇️
coverage-3.9 98.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@JiriPavela JiriPavela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, let's merge it :)

@tfiedor
Copy link
Collaborator

tfiedor commented Dec 6, 2023

Fuck you both.

@tfiedor
Copy link
Collaborator

tfiedor commented Dec 6, 2023

I will review, and merge it later today. I don't think there will be any issues (though I actually solved this issue in paralel PR, that I will soon open).

@tfiedor tfiedor merged commit b59a3bc into Perfexionists:devel Dec 6, 2023
11 checks passed
@HarryMichal HarryMichal deleted the tfiedor-is-dead-long-live-perfexionists branch December 8, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants