Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitignore #122

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

HarryMichal
Copy link
Contributor

@HarryMichal HarryMichal commented Oct 6, 2023

This is a combination of GitHub's .gitignore's for Python[0] and JetBrains[1] and a bit of Perun on top..

[0] https://github.com/github/gitignore/blob/main/Python.gitignore
[1] https://github.com/github/gitignore/blob/main/Global/JetBrains.gitignore

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba11799) 98.04% compared to head (b1be302) 98.03%.
Report is 1 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #122      +/-   ##
==========================================
- Coverage   98.04%   98.03%   -0.02%     
==========================================
  Files         129      129              
  Lines        8686     8687       +1     
==========================================
  Hits         8516     8516              
- Misses        170      171       +1     
Flag Coverage Δ
coverage-3.10 97.88% <ø> (-0.12%) ⬇️
coverage-3.11 97.98% <ø> (+0.29%) ⬆️
coverage-3.9 97.91% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tfiedor tfiedor requested review from JiriPavela and tfiedor October 9, 2023 08:23
Copy link
Collaborator

@tfiedor tfiedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the new .gitignore is good (I guess generated by some tool), but I would squash the idea directories (and maybe, if there are more similar cases that I overlooked, I would squash them as well; I'd rather keep the stuff short and concise).

.gitignore Outdated Show resolved Hide resolved
This is a combination of GitHub's .gitignore's for Python[0] and
JetBrains[1] and a bit of Perun on top.

[0] https://github.com/github/gitignore/blob/main/Python.gitignore
[1] https://github.com/github/gitignore/blob/main/Global/JetBrains.gitignore
@tfiedor tfiedor merged commit f261160 into Perfexionists:devel Oct 26, 2023
8 of 9 checks passed
@HarryMichal HarryMichal deleted the gitignore-update branch October 26, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants