Daily rc sync to master #6789
Merged
Daily rc sync to master #6789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
**Context:** We weren't actually validating that the `device_vjp=True` was supported. This allowed strange circumstances where you would have `device_vjp=True`, but not support device derivatives at all, and this could lead to incorrect answers. **Description of the Change:** **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:**
**Context:** When running tests locally, I was getting failures like: ``` FAILED tests/devices/default_qubit/test_default_qubit.py::TestPostselection::test_postselection_invalid_finite_shots[shots1-mp2-expected_shape2-False-jax] - ValueError: Probabilities contain NaN ``` We had logic to catch the error `'probabilities contain NaN'`, but something about my versioning gives a slightly different capitalization. To prevent this happening of other people, I updated the error catching to be capitalization independent. **Description of the Change:** Catch both `"Probabilities contain NaN"` and `"probabilities contain NaN"`. **Benefits:** Tests pass locally for my environment. **Possible Drawbacks:** Still a bit error prone. I'm also not sure what about my environment gives different capitalization. **Related GitHub Issues:** --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Pietropaolo Frisoni <[email protected]> Co-authored-by: Mudit Pandey <[email protected]> Co-authored-by: ringo-but-quantum <[email protected]> Co-authored-by: Andrija Paurevic <[email protected]>
**Context:** PR #6019 only fixes `BasisRotation` when using backprop on `default.qubit`. It is not jit compatible on any other device. This is because `unitary_matrix` was being considered a hyperparameter, not a piece of data. So we could not detect that the matrix was a tracer and we were in jitting mode, and we could not convert the matrix back into numpy data. **Description of the Change:** Make `unitary_matrix` a piece of data instead of a hyperparameter. This allows us to detect when it is being jitted. As a by-product, I also made it valid pytree. By making `unitary_matrix` a piece of data, we were able to get rid of the custom comparison method in `qml.equal`. **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** [sc-51603] Fixes #6004
PietropaoloFrisoni
approved these changes
Jan 9, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6789 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 476 476
Lines 45222 45222
=======================================
Hits 45045 45045
Misses 177 177 ☔ View full report in Codecov by Sentry. |
astralcai
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.