Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.40 changelog - Generalized Trotter products #6763

Merged
merged 5 commits into from
Jan 10, 2025
Merged

v0.40 changelog - Generalized Trotter products #6763

merged 5 commits into from
Jan 10, 2025

Conversation

isaacdevlugt
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@isaacdevlugt isaacdevlugt self-assigned this Jan 6, 2025
@isaacdevlugt isaacdevlugt marked this pull request as ready for review January 6, 2025 20:33
@codecov Codecov
Copy link

codecov bot commented Jan 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v0.40.0-changelog@9badedf). Learn more about missing BASE report.

Additional details and impacted files 
@@                 Coverage Diff                  @@
##             v0.40.0-changelog    #6763   +/-   ##
====================================================
  Coverage                     ?   99.60%           
====================================================
  Files                        ?      476           
  Lines                        ?    45237           
  Branches                     ?        0           
====================================================
  Hits                         ?    45060           
  Misses                       ?      177           
  Partials                     ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PietropaoloFrisoni PietropaoloFrisoni added this to the v0.40 milestone Jan 8, 2025
@AntonNI8 AntonNI8 marked this pull request as draft January 9, 2025 15:48
AntonNI8
AntonNI8 reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@AntonNI8 AntonNI8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions, but looks good overall!

doc/releases/changelog-0.40.0.md Outdated Show resolved Hide resolved
doc/releases/changelog-0.40.0.md Outdated Show resolved Hide resolved
doc/releases/changelog-0.40.0.md Outdated Show resolved Hide resolved
doc/releases/changelog-0.40.0.md Outdated Show resolved Hide resolved
@isaacdevlugt isaacdevlugt marked this pull request as ready for review January 10, 2025 20:55
@isaacdevlugt isaacdevlugt requested a review from AntonNI8 January 10, 2025 21:00
@isaacdevlugt isaacdevlugt merged commit 4e3b45f into v0.40.0-changelog Jan 10, 2025
51 checks passed
@isaacdevlugt isaacdevlugt deleted the v0.40.0-changelog-trotter branch January 10, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSGuala DSGuala Awaiting requested review from DSGuala

@AntonNI8 AntonNI8 Awaiting requested review from AntonNI8

Assignees

@isaacdevlugt isaacdevlugt

Labels
None yet
Projects
None yet
Milestone
v0.40
Development

Successfully merging this pull request may close these issues.
3 participants
@isaacdevlugt @AntonNI8 @PietropaoloFrisoni