Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with trigger_benchmark being too strict with the permission check #6731

Merged
merged 3 commits into from
Dec 19, 2024
+3 −3
Merged

Fix issue with trigger_benchmark being too strict with the permission check #6731

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f32e410
Fix issue with trigger_benchmark being too strict with the permission…
rashidnhm Dec 18, 2024
4786196
Merge branch 'master' into sc-80243-update-benchmark-trigger-check
rashidnhm Dec 18, 2024
4636f4c
Merge branch 'master' into sc-80243-update-benchmark-trigger-check
rashidnhm Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/trigger_benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ jobs:
username: user
});
const userPermissions = data.user.permissions;
const permission = userPermissions.admin || userPermissions.maintain;
const permission = userPermissions.admin || userPermissions.maintain || (userPermissions.write || userPermissions.push);
rashidnhm marked this conversation as resolved.
Show resolved Hide resolved

console.log(`User '${user}' has admin/maintain access => ${permission}`);
console.log(`User '${user}' has admin/maintain/write access => ${permission}`);

return permission;

Expand Down Expand Up @@ -85,7 +85,7 @@ jobs:
}

- name: React to original comment indicating webhook sent
if: steps.comment_user.outputs.result == 'true'
if: steps.comment_body.outputs.triggers_benchmark == 'true' && steps.comment_user.outputs.result == 'true'
uses: actions/github-script@v7
env:
REPO_OWNER: ${{ steps.repo_info.outputs.REPO_OWNER }}
Expand Down
Loading