Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise a warning when user-applied dynamic_one_shot is ignored #6701

Merged
merged 9 commits into from
Dec 11, 2024
Merged

Raise a warning when user-applied dynamic_one_shot is ignored #6701

merged 9 commits into from
Dec 11, 2024

Conversation

astralcai
Copy link
Contributor

Fixes #6551
[sc-77877]

@github-actions GitHub Actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.61%. Comparing base (09f09e4) to head (6bcb376).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6701      +/-   ##
==========================================
- Coverage   99.62%   99.61%   -0.01%     
==========================================
  Files         468      468              
  Lines       44144    44149       +5     
==========================================
+ Hits        43977    43979       +2     
- Misses        167      170       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

isaacdevlugt
isaacdevlugt approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@isaacdevlugt isaacdevlugt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @astralcai !

pennylane/transforms/dynamic_one_shot.py Outdated Show resolved Hide resolved
pennylane/transforms/dynamic_one_shot.py Outdated Show resolved Hide resolved
pennylane/transforms/dynamic_one_shot.py Outdated Show resolved Hide resolved
pennylane/workflow/_setup_transform_program.py Outdated Show resolved Hide resolved
mudit2812
mudit2812 reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, few comments.

pennylane/transforms/dynamic_one_shot.py Outdated Show resolved Hide resolved
pennylane/workflow/_setup_transform_program.py Outdated Show resolved Hide resolved
@astralcai astralcai requested a review from mudit2812 December 11, 2024 19:46
@astralcai astralcai enabled auto-merge (squash) December 11, 2024 21:03
@astralcai astralcai merged commit bbd8f3d into master Dec 11, 2024
46 checks passed
@astralcai astralcai deleted the user-one-shot branch December 11, 2024 22:03
@astralcai astralcai mentioned this pull request Dec 12, 2024
Merged
astralcai added a commit that referenced this pull request Dec 12, 2024
@astralcai
Add changelog entry for previous PR (#6712)
ccba66f 
I forgot to add a changelog entry to
#6701 (Oooooooops)
mudit2812 added a commit that referenced this pull request Dec 13, 2024
@astralcai @isaacdevlugt @mudit2812
Raise a warning when user-applied dynamic_one_shot is ignored (#6701)
903dc2d 
Fixes #6551
[sc-77877]

---------

Co-authored-by: Isaac De Vlugt <[email protected]>
Co-authored-by: Mudit Pandey <[email protected]>
mudit2812 pushed a commit that referenced this pull request Dec 13, 2024
@astralcai @mudit2812
Add changelog entry for previous PR (#6712)
94abed6 
I forgot to add a changelog entry to
#6701 (Oooooooops)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaacdevlugt isaacdevlugt isaacdevlugt approved these changes

@mudit2812 mudit2812 mudit2812 approved these changes

@albi3ro albi3ro Awaiting requested review from albi3ro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] dynamic_one_shot is ignored when applied as a QNode transform.
3 participants
@astralcai @mudit2812 @isaacdevlugt