-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QSP iterative angle solver #6694
base: master
Are you sure you want to change the base?
Conversation
Great! Thanks for working on it :) |
thx for the support.. just a couple:
|
Don't worry about jit integration. The code itself will not have jit. But it would be good to create a test to check that it will indeed work with jit. This is an example where jit is tested |
|
🚀 Thanks for opening this PR @cvqmm ! |
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
doc/releases/changelog-dev.md
file, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint
, and thenrun
pylint pennylane/path/to/file.py
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: QSP angle solver
Description of the Change: determine the QSP circuit angles through an iterative optimization procedure https://journals.aps.org/pra/abstract/10.1103/PhysRevA.103.042419
Benefits:
Possible Drawbacks:
Related GitHub Issues: