Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove warning example qsvt #6693

Merged
merged 8 commits into from
Dec 10, 2024
Merged

Remove warning example qsvt #6693

merged 8 commits into from
Dec 10, 2024

Conversation

KetpuntoG
Copy link
Contributor

Context:

  • The example shows a warning due to the deprecation of qml.qsvt_legacy. It has been updated
  • This PR also add a little modification to accept scalars and arrays as qsvt input (solves this comment)

@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63%. Comparing base (0a0e208) to head (27f1bda).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6693   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files         468      468           
  Lines       44132    44132           
=======================================
  Hits        43973    43973           
  Misses        159      159

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Jaybsoni
Jaybsoni approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@Jaybsoni Jaybsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏼

austingmhuang
austingmhuang approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@austingmhuang austingmhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Make sure to address the codefactor issue.

@KetpuntoG KetpuntoG merged commit f8df7ea into master Dec 10, 2024
46 checks passed
@KetpuntoG KetpuntoG deleted the qsvt_re branch December 10, 2024 15:37
mudit2812 pushed a commit that referenced this pull request Dec 13, 2024
@KetpuntoG @Jaybsoni @mudit2812
Remove warning example qsvt (#6693)
9491c18 
**Context:**

- The example shows a warning due to the deprecation of qml.qsvt_legacy.
It has been updated
- This PR also add a little modification to accept scalars and arrays as
qsvt input ([solves this
comment](PennyLaneAI/qml#1276 (comment)))

---------

Co-authored-by: Jay Soni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austingmhuang austingmhuang austingmhuang approved these changes

@Jaybsoni Jaybsoni Jaybsoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KetpuntoG @Jaybsoni @austingmhuang