-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean-up Wires
object usage across source code
#6689
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6689 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 475 475
Lines 45102 45115 +13
=======================================
+ Hits 44925 44938 +13
Misses 177 177 ☔ View full report in Codecov by Sentry. |
wires=None
across codebase when appropriateWires
usage across source code
Wires
usage across source codeWires
object usage across source code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few small comments here and there, see what you think :)
Co-authored-by: lillian542 <[email protected]>
This reverts commit 3ab6174.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just one clarification from me.
Regarding the discussion about changelog entries, can we have a unique changelog entry for all the improvements you implemented regarding the tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tidying this up :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Context:
Follow up to #6713.
It is not possible to initialize a
Wires
object withwires=None
after #6713. However, we should not be usingwires=None
in our code-base unless it's appropriate.Description of the Change:
This PR reviews the code-base to ensure that
wires=None
does not occur where it is not applicable. When appropriate, it updates the default towires=()
or uses no default at all.Benefits: Code clean-up.
Possible Drawbacks: None identified.
[sc-78998]