-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite tests for split_non_commuting
#6687
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6687 +/- ##
========================================
Coverage 99.61% 99.62%
========================================
Files 473 474 +1
Lines 44355 44617 +262
========================================
+ Hits 44186 44448 +262
Misses 169 169 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @astralcai
A few questions from my side:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many previous questions resolved without comment. Same questions/prompts apply.
Co-authored-by: Christina Lee <[email protected]>
This is an attempt to refactor the tests for one of the transforms, hoping to set a standard for future transform tests. For each transform, we should have:
[sc-72000]
[sc-72519]