Fix bug in autograph implementation for ctrl and adjoint #6685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e into autograph_ctrl_flow
lillian542
changed the title
lillian542
commented
Dec 6, 2024
This comment was marked as resolved.
This comment was marked as resolved.
|
The documentation check failures are because I accidentally based this PR on the Autograph documentation PR, so that is resolved there and not relevant for this PR |
astralcai
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The checks in the existing implementation of autograph have handling for conversion if a function is passed to
qml.ctrlorqml.adjoint.Unfortunately, these checks were breaking the case where a fully initialized operator was passed to
qml.ctrlorqml.adjoint, because they expect the check to always receive a callable.Description of the Change:
We have autograph track the
_capture_adjoint_transformand_capture_ctrl_transformfunctions instead, since at that point the function really does always receive a callable.[sc-80037]