Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for current autograph support and sharp bits #6678

Merged
merged 133 commits into from
Dec 13, 2024
Merged

Documentation for current autograph support and sharp bits #6678

merged 133 commits into from
Dec 13, 2024

Conversation

lillian542
Copy link
Contributor

@lillian542 lillian542 commented Dec 5, 2024 •
edited
Loading

  • Updates docstring for make_plxpr,
  • adds run_autograph to the capture module docs page
  • gives run_autograph a more comprehensive docstring, and
  • adds a sharp-bits guide for Autograph (currently only linked through the make_plxpr and run_autograph docstring)

[sc-71827]

andrijapau and others added 30 commits October 3, 2024 15:07
@andrijapau
add user decompose function
5dfc38f
@andrijapau
code factor
f1d9eee
@andrijapau
update changelog
b24c97b
@andrijapau
improve decomposition function
0d3bfb6
@andrijapau
codefactor fix
0d66209
@andrijapau
added modified generator
a25d6ba
@lillian542
copy code from catalyst
2ad96ac
@lillian542
remove catalyst from __init__ and transformer files
c471c0b
@lillian542
replace many catalyst dependencies/mentions
49c0fac
@lillian542
copy tests from catalyst
5dd1d42
@lillian542
update imports
c94da87
@lillian542
[ci skip]
ab8ae7a
@lillian542
Merge branch 'master' into add_autograph
ac7d53e
@lillian542
import autograph module in capture
4a6bdf3
@lillian542
remove final catalyst dependencies from ag_primitives
2c2f1dd
@lillian542
record queueing in FlatFn so we can access program_length in ag_primi…
9b18b97 
…tives
@lillian542
most conditional tests work
cf92f2a
@lillian542
initial removal of queueing dependency
7a21764
@lillian542
the current state of the tests
72b3e42
@lillian542
remove index setting and logical operators
fee16ff
@lillian542
formatting
3ccd0e0
@lillian542
remove fallback
1ab03f3
@lillian542
remove disable_autograph
2bfaf72
@lillian542
remove autograph_include
42ce1e8
@lillian542
Merge branch 'master' into autograph_ctrl_flow
d3a807c
@lillian542
remove strict_conversion and ignore_fallbacks
fa0b415
@lillian542
Tidying up
54b3036
@lillian542
Tidying up more
26cbde4
@lillian542
fix more tests
211bd81
@lillian542
Merge branch 'autograph_ctrl_flow' of github.com:PennyLaneAI/pennylan…
6be1ff5 
…e into autograph_ctrl_flow
@isaacdevlugt
Copy link
Contributor

My current understanding from @isaacdevlugt is that we want to link to it the relevant places (so its linked through the make_plxpr and run_autograph docstrings), but we don't want it showing up in the sidebar yet

Yep this is fine to be an internal document for now :)

albi3ro
albi3ro approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main concern is linking a document on stable instead of latest. This link will be broken till a release, and then always be a release out of date. This is also makes it hard to validate over time. But at the same time, I'm really not sure how to improve it. So I won't block for that.

Thanks for these docs 👍

isaacdevlugt
isaacdevlugt approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@isaacdevlugt isaacdevlugt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side! 🚀

astralcai
astralcai approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@astralcai astralcai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No further questions from me 🚀

@lillian542 lillian542 enabled auto-merge (squash) December 12, 2024 22:15
@lillian542 lillian542 added the merge-ready ✔️ All tests pass and the PR is ready to be merged. label Dec 12, 2024
@albi3ro albi3ro disabled auto-merge December 13, 2024 16:05
@albi3ro albi3ro merged commit 2c9d4c1 into master Dec 13, 2024
46 checks passed
@albi3ro albi3ro deleted the autograph_docs branch December 13, 2024 16:05
mudit2812 added a commit that referenced this pull request Dec 13, 2024
@lillian542 @andrijapau
@albi3ro @mudit2812 @PietropaoloFrisoni @JerryChen97 @isaacdevlugt @josh146
Documentation for current autograph support and sharp bits (#6678)
dfd487d 
- Updates docstring for `make_plxpr`, 
- adds `run_autograph` to the capture module docs page 
- gives `run_autograph` a more comprehensive docstring, and 
- adds a sharp-bits guide for Autograph (currently only linked through
the `make_plxpr` and `run_autograph` docstring)

[sc-71827]

---------

Co-authored-by: andrijapau <[email protected]>
Co-authored-by: Christina Lee <[email protected]>
Co-authored-by: Mudit Pandey <[email protected]>
Co-authored-by: Pietropaolo Frisoni <[email protected]>
Co-authored-by: Yushao Chen (Jerry) <[email protected]>
Co-authored-by: Isaac De Vlugt <[email protected]>
Co-authored-by: Josh Izaac <[email protected]>
austingmhuang pushed a commit that referenced this pull request Dec 13, 2024
@lillian542 @andrijapau
@albi3ro @mudit2812 @PietropaoloFrisoni @JerryChen97 @isaacdevlugt @josh146 @austingmhuang
Documentation for current autograph support and sharp bits (#6678)
10d5c7c 
- Updates docstring for `make_plxpr`, 
- adds `run_autograph` to the capture module docs page 
- gives `run_autograph` a more comprehensive docstring, and 
- adds a sharp-bits guide for Autograph (currently only linked through
the `make_plxpr` and `run_autograph` docstring)

[sc-71827]

---------

Co-authored-by: andrijapau <[email protected]>
Co-authored-by: Christina Lee <[email protected]>
Co-authored-by: Mudit Pandey <[email protected]>
Co-authored-by: Pietropaolo Frisoni <[email protected]>
Co-authored-by: Yushao Chen (Jerry) <[email protected]>
Co-authored-by: Isaac De Vlugt <[email protected]>
Co-authored-by: Josh Izaac <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh146 josh146 josh146 left review comments

@isaacdevlugt isaacdevlugt isaacdevlugt approved these changes

@astralcai astralcai astralcai approved these changes

@albi3ro albi3ro albi3ro approved these changes

Assignees
No one assigned
Labels
merge-ready ✔️ All tests pass and the PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lillian542 @isaacdevlugt @josh146 @albi3ro @astralcai @andrijapau