Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add resource methods to some templates (TrotterProduct, Exp, StatePrep, QPE) #6677

Open
wants to merge 14 commits into
base: resource_symbolic_decomps
Choose a base branch
from

Conversation

Jaybsoni
Copy link
Contributor

@Jaybsoni Jaybsoni commented Dec 5, 2024

Context:
Adding resource methods to various templates in the new resource estimation framework.

Description of the Change:

Benefits:

@Jaybsoni Jaybsoni added the WIP 🚧 Work-in-progress label Dec 5, 2024
@Jaybsoni Jaybsoni requested review from willjmax and soranjh December 5, 2024 20:41
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@Jaybsoni
Copy link
Contributor Author

Jaybsoni commented Dec 5, 2024

[sc-79016]

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.60%. Comparing base (64fac4a) to head (27024b4).
Report is 9 commits behind head on resource_symbolic_decomps.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           resource_symbolic_decomps    #6677   +/-   ##
==========================================================
  Coverage                      99.60%   99.60%           
==========================================================
  Files                            476      476           
  Lines                          45232    45232           
==========================================================
  Hits                           45055    45055           
  Misses                           177      177           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@willjmax willjmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes needed to make this behave in a way that is consistent with other symbolic ops. Also, seems like there is way too much stuff in trotter.py.

pennylane/labs/resource_estimation/ops/op_math/symbolic.py Outdated Show resolved Hide resolved
pennylane/labs/resource_estimation/ops/op_math/symbolic.py Outdated Show resolved Hide resolved
pennylane/labs/resource_estimation/ops/op_math/symbolic.py Outdated Show resolved Hide resolved
pennylane/labs/resource_estimation/ops/op_math/symbolic.py Outdated Show resolved Hide resolved
pennylane/labs/resource_estimation/ops/op_math/symbolic.py Outdated Show resolved Hide resolved
pennylane/labs/resource_estimation/templates/trotter.py Outdated Show resolved Hide resolved
pennylane/labs/resource_estimation/templates/trotter.py Outdated Show resolved Hide resolved
pennylane/labs/resource_estimation/templates/trotter.py Outdated Show resolved Hide resolved
pennylane/labs/resource_estimation/templates/trotter.py Outdated Show resolved Hide resolved
@Jaybsoni Jaybsoni requested a review from willjmax January 9, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP 🚧 Work-in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants