-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix consistency of QNode
results processing
#6568
Conversation
Hello. You may have forgotten to update the changelog!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6568 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 451 451
Lines 42293 42293
=======================================
Hits 42062 42062
Misses 231 231 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
I guess we should permanently turn off the too-many-positional of codefac |
Context:
The output of QNode execution was not consistent based on the type of the qfunc output,
Description of the Change:
Updates how the results of the QNode execution gets "type-converted" according to the
qfunc_output
.After this fix we get consistency,
Benefits: Consistency
Possible Drawbacks: Output of QNode execution may look different than people are used to. A direct example is needed to change some tests to squeeze out the new dimension that has been introduced.
Related GitHub Issue: Fixes #6540
[sc-77682]