Fix zero-jvps with shot vectors #6219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astralcai
approved these changes
Sep 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6219 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 445 445
Lines 42411 42417 +6
=======================================
+ Hits 42255 42261 +6
Misses 156 156 ☔ View full report in Codecov by Sentry. |
albi3ro
reviewed
Sep 5, 2024
albi3ro
reviewed
Sep 5, 2024
albi3ro
reviewed
Sep 5, 2024
Co-authored-by: Christina Lee <[email protected]>
albi3ro
approved these changes
Sep 9, 2024
mudit2812
pushed a commit
that referenced
this pull request
Sep 10, 2024
**Context:** If a tape has no trainable parameters, generic zero-valued JVPs are created for it in JVP calculations. However, these generic calculations are not taking shot vectors correctly into account, also because they do not use `MeasurementProcess.shape` correctly. **Description of the Change:** Change the generic zero-valued JVPs so they are compatible with shot vectors. **Benefits:** One bug less. **Possible Drawbacks:** N/A **Related GitHub Issues:** Fixes #6220 [sc-73033] --------- Co-authored-by: Christina Lee <[email protected]>
mudit2812
pushed a commit
that referenced
this pull request
Sep 12, 2024
**Context:** If a tape has no trainable parameters, generic zero-valued JVPs are created for it in JVP calculations. However, these generic calculations are not taking shot vectors correctly into account, also because they do not use `MeasurementProcess.shape` correctly. **Description of the Change:** Change the generic zero-valued JVPs so they are compatible with shot vectors. **Benefits:** One bug less. **Possible Drawbacks:** N/A **Related GitHub Issues:** Fixes #6220 [sc-73033] --------- Co-authored-by: Christina Lee <[email protected]>
mudit2812
pushed a commit
that referenced
this pull request
Sep 16, 2024
**Context:** If a tape has no trainable parameters, generic zero-valued JVPs are created for it in JVP calculations. However, these generic calculations are not taking shot vectors correctly into account, also because they do not use `MeasurementProcess.shape` correctly. **Description of the Change:** Change the generic zero-valued JVPs so they are compatible with shot vectors. **Benefits:** One bug less. **Possible Drawbacks:** N/A **Related GitHub Issues:** Fixes #6220 [sc-73033] --------- Co-authored-by: Christina Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
If a tape has no trainable parameters, generic zero-valued JVPs are created for it in JVP calculations.
However, these generic calculations are not taking shot vectors correctly into account, also because they do not use
MeasurementProcess.shapecorrectly.Description of the Change:
Change the generic zero-valued JVPs so they are compatible with shot vectors.
Benefits:
One bug less.
Possible Drawbacks:
N/A
Related GitHub Issues:
Fixes #6220
Related Shortcut Stories:
[sc-73033]